[go] fix hermes debugging not enabled on release builds #26577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanjhughes
approved these changes
Jan 22, 2024
Kudo
added a commit
that referenced
this pull request
Jan 22, 2024
fixed #26044 close ENG-11034 we need to enable hermes debugging feature even on expo-go release build. previously we did this when generating versioned hermes. since we now use unversioned variant to serve sdk 50, we should change our way to enable the hermes debugging feature. this pr with expo/react-native#33 are to enable the `HERMES_ENABLE_DEBUGGER` for all variants note that: this pr would also increase ios build time because we now building hermes from source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
fixed #26044
close ENG-11034
How
we need to enable hermes debugging feature even on expo-go release build. previously we did this when generating versioned hermes. since we now use unversioned variant to serve sdk 50, we should change our way to enable the hermes debugging feature.
this pr with expo/react-native#33 are to enable the
HERMES_ENABLE_DEBUGGERfor all variantsnote that: this pr would also increase ios build time because we now building hermes from source.
Test Plan
test js inspector on android/ios versioned expo-go (release builds) + sdk 50 project
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).