-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[camera] Fix barcodeTypes prop in types and in Swift #26888
Conversation
Hi @byudaniel - The name of the prop is correct, |
If you do a case search in See also expo/packages/expo-camera/src/next/Camera.types.ts Lines 399 to 400 in b3f788a
|
@byudaniel - yes so the correct fix is to fix the casing on the Typescript type |
@alanjhughes - OK, so I'll update the PR to update the Swift code and the types and revert the changes to the Kotlin files. |
@byudaniel - yes, that'd be great! |
@byudaniel - looking good. Have you checked that everything is working correctly on the |
@byudaniel the example screen isn't using the correct name now. |
@alanjhughes I confirmed that it is working in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you for your contribution! 👍
Why
Android was not receiving the barCodeTypes prop, so when scanning barcodes it was scanning for every type of barcode.
How
I fixed the casing on the prop to be consistent with iOS and the docs.
Test Plan
Tested manually with Galaxy 21 and S22 Ultra to ensure it only picked up the specified barcode type.
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).