Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-local-authentication] Add support for promptMessage, cancelLabel and disableDeviceFallback on Android #8219

Merged
merged 10 commits into from
May 18, 2020
Merged

[expo-local-authentication] Add support for promptMessage, cancelLabel and disableDeviceFallback on Android #8219

merged 10 commits into from
May 18, 2020

Conversation

diegolmello
Copy link
Contributor

Why

Add expo-local-authentication options on Android.

How

Following BiometricPrompt.PromptInfo docs and keeping same behaviour as iOS.

Test Plan

Run tests

lukmccall
lukmccall requested changes May 11, 2020
View reviewed changes
Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for contributing 🎉 Overall it looks good 🏅However, I've left some comments ;)

packages/expo-local-authentication/src/LocalAuthentication.ts Show resolved Hide resolved
...cation/android/src/main/java/expo/modules/localauthentication/LocalAuthenticationModule.java Outdated Show resolved Hide resolved
...cation/android/src/main/java/expo/modules/localauthentication/LocalAuthenticationModule.java Outdated Show resolved Hide resolved
...cation/android/src/main/java/expo/modules/localauthentication/LocalAuthenticationModule.java Outdated Show resolved Hide resolved
@diegolmello
Copy link
Contributor Author

@lukmccall Done! Thanks for your review :)

@diegolmello diegolmello requested a review from lukmccall May 15, 2020 14:08
@lukmccall
Copy link
Contributor

Could you rebase your branch? Maybe this will fix some CI tests. If this doesn't help, don't bother ;)

@diegolmello diegolmello force-pushed the android.add-local-authentication-labels branch from f634569 to ef6e686 Compare May 15, 2020 16:24
@diegolmello
Copy link
Contributor Author

Could you rebase your branch? Maybe this will fix some CI tests. If this doesn't help, don't bother ;)

hahaha done!

@lukmccall
Copy link
Contributor

It seems that you still need to rebuild the expo-local-authentication package. To do it, run yarn build in the package folder.

@diegolmello
Copy link
Contributor Author

@lukmccall Done!

lukmccall
lukmccall approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇
I'll merger it ;) But first, you need to add one more thing. Please, update changelog - it's located under packages/expo-local-authentication/CHANGELOG.md. Sorry for not telling you this earlier.

@diegolmello
Copy link
Contributor Author

LGTM 🥇
I'll merger it ;) But first, you need to add one more thing. Please, update changelog - it's located under packages/expo-local-authentication/CHANGELOG.md. Sorry for not telling you this earlier.

@lukmccall Np. Should I add it under New features as [expo-local-authentication] Add options on Android?

@lukmccall
Copy link
Contributor

@lukmccall Np. Should I add it under New features as [expo-local-authentication] Add options on Android?

Yes, it seems to be a good section ;)

@diegolmello
Copy link
Contributor Author

@lukmccall Done! (:

@lukmccall lukmccall changed the title [expo-local-authentication] Add options on Android [expo-local-authentication] Add support for promptMessage, cancelLabel and disableDeviceFallback on Android May 18, 2020
@diegolmello @lukmccall
Update packages/expo-local-authentication/CHANGELOG.md
de58557 
Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@student.uj.edu.pl>
@lukmccall lukmccall merged commit 425d5cc into expo:master May 18, 2020
@diegolmello
Copy link
Contributor Author

@lukmccall Thanks for your lightning fast reviews 👊

@byCedric
Copy link
Member

Awesome! I think this fixes #8286 and #7583 too, right?

@lukmccall
Copy link
Contributor

@byCedric, yes, it should fix it ;)

This was referenced May 19, 2020
Closed
Closed
@LinusU
Copy link
Contributor

LinusU commented May 21, 2020

Awesome! 👏 😍

@tsapeta tsapeta mentioned this pull request Jun 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukmccall lukmccall lukmccall approved these changes

@tsapeta tsapeta Awaiting requested review from tsapeta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diegolmello @lukmccall @byCedric @LinusU