Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu-bar] refresh Settings window, align more to native #121

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Jan 3, 2024

Why

Unify a bit more Settings window and panes appearance.

How

Mimic a bit more native appearance, tweak spacing, typography changes, improve buttons visibility especially in dark mode, prevent content shift on account change/logout.

Test Plan

The changes have been tested locally, Setting works as intended.

Preview

Screenshot 2024-01-03 at 00 17 21
Screenshot 2024-01-03 at 00 17 26

Copy link
Member

@gabrieldonadel gabrieldonadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, just need to fix the launch button and update the changelog

apps/menu-bar/src/components/Button.tsx Show resolved Hide resolved
@Simek Simek merged commit 35d9387 into main Jan 3, 2024
1 check failed
@Simek Simek deleted the @simek/menu-bar-setting-refresh branch January 3, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants