Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[menu-bar] Fix Settings window size when opening it from the context menu #127

Merged
merged 2 commits into from
Jan 5, 2024
Merged

[menu-bar] Fix Settings window size when opening it from the context menu #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbb4cfe
[menu-bar] Fix Settings window size when opening it from the context …
gabrieldonadel Jan 4, 2024
6d09c66
Add changelog entry
gabrieldonadel Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- Fix device selection logic when a simulator or device is no longer available. ([#114](https://github.com/expo/orbit/pull/114) by [@gabrieldonadel](https://github.com/gabrieldonadel))
- Fix projects section height when the user has less than 3 projects. ([#119](https://github.com/expo/orbit/pull/119) by [@gabrieldonadel](https://github.com/gabrieldonadel))
- Fix installing apps on Android real devices. ([#123](https://github.com/expo/orbit/pull/123) by [@gabrieldonadel](https://github.com/gabrieldonadel))
- Fix Settings window size when opening it from the context menu. ([#127](https://github.com/expo/orbit/pull/127) by [@gabrieldonadel](https://github.com/gabrieldonadel))

### 🛠 Breaking changes

Expand Down
8 changes: 7 additions & 1 deletion apps/menu-bar/macos/ExpoMenuBar-macOS/AppDelegate.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,13 @@ - (void)quitAction:(id)sender {

- (void)settingsAction:(id)sender {
WindowNavigator *windowNavigator = [WindowNavigator shared];
[windowNavigator openWindow:@"Settings" options:@{}];
[windowNavigator openWindow:@"Settings" options:@{
@"windowStyle": @{
@"titlebarAppearsTransparent": @YES,
@"height": @(580.0),
@"width": @(500.0)
}
}];
}

- (void)openPopover {
Expand Down