[menu-bar] Migrate FilePicker to Expo Modules #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanjhughes
requested changes
Jan 9, 2024
Comment on lines
47
to
32
| AsyncFunction("pickFolder"){ (promise: Promise) in | ||
| DispatchQueue.main.async { | ||
| let panel = NSOpenPanel() | ||
| panel.allowsMultipleSelection = false | ||
| panel.canChooseFiles = false | ||
| panel.canChooseDirectories = true | ||
| panel.canCreateDirectories = true | ||
|
|
||
| if panel.runModal() == NSApplication.ModalResponse.OK { | ||
| promise.resolve(panel.url?.path) | ||
| } else { | ||
| promise.reject(Exception(name: "FILE_PICKER_ERROR", description: "NSModalResponseCancel")) | ||
| } | ||
| } | ||
| } |
tsapeta
reviewed
Jan 10, 2024
| Name("FilePicker") | ||
|
|
||
| AsyncFunction("pickFileWithFilenameExtension"){ (filenameExtensions: [String], prompt: String, promise: Promise) in | ||
| DispatchQueue.main.async { |
gabrieldonadel
force-pushed
the
@gabrieldonadel/migrate-file-picker-to-expo-modules
branch
from
89807c4
to
f1089ff
Compare
alanjhughes
approved these changes
Jan 10, 2024
tsapeta
approved these changes
Jan 10, 2024
tsapeta
force-pushed
the
@tsapeta/install-expo-modules
branch
2 times, most recently
from
247da92
to
19d0d03
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/migrate-file-picker-to-expo-modules
branch
2 times, most recently
from
e8d8371
to
33dd18b
Compare
Co-authored-by: Alan Hughes <30924086+alanjhughes@users.noreply.github.com>
gabrieldonadel
force-pushed
the
@gabrieldonadel/migrate-file-picker-to-expo-modules
branch
from
c65db43
to
5f7bb65
Compare
gabrieldonadel
deleted the
@gabrieldonadel/migrate-file-picker-to-expo-modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Now that expo modules supports macOS, we can start to slowly migrate our modules to use the Sweet API
How
Migrate FilePicker to use Expo Modules
Test Plan
Screen.Recording.2024-01-09.at.18.50.09.mov