[menu-bar] Migrate MenuBar to Expo Modules #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @alanjhughes, thanks for opening this PR and migrating the MenuBar module. I've been testing this locally and I'm getting this error when trying to setEnvVars. I'm not sure if we can use the speed syntax with Screen.Recording.2024-01-11.at.22.39.40.mov |
|
@gabrieldonadel Should have realised that when I had to explicitly add the constants. Those objects mustn't be iterable. Updated |
gabrieldonadel
requested changes
Jan 12, 2024
gabrieldonadel
approved these changes
Jan 12, 2024
tsapeta
reviewed
Jan 15, 2024
tsapeta
force-pushed
the
@tsapeta/install-expo-modules
branch
2 times, most recently
from
247da92
to
19d0d03
Compare
alanjhughes
force-pushed
the
@alanhughes/migrate-menu-bar-to-expo-modules
branch
from
f11ad6f
to
f979c69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Expo modules is now supported on MacOS
How
Migrate MenuBar to use Expo Modules
Test Plan
Running dev and release side by side. Everything seems to work as expected.