-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[menu-bar][cli] Add basic support for launching Expo updates #134
Merged
gabrieldonadel
merged 12 commits into
main
from
@gabrieldonadel/add-support-for-updates
Jan 19, 2024
Merged
[menu-bar][cli] Add basic support for launching Expo updates #134
gabrieldonadel
merged 12 commits into
main
from
@gabrieldonadel/add-support-for-updates
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
force-pushed
the
@gabrieldonadel/add-support-for-updates
branch
3 times, most recently
from
January 16, 2024 23:39
c38c767
to
54de00c
Compare
gabrieldonadel
changed the base branch from
@gabrieldonadel/cli-auth
to
@gabrieldonadel/add-graphql-to-cli
January 16, 2024 23:40
gabrieldonadel
force-pushed
the
@gabrieldonadel/add-support-for-updates
branch
2 times, most recently
from
January 16, 2024 23:49
9d91220
to
0b804e8
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/add-graphql-to-cli
branch
from
January 18, 2024 13:37
5a483ef
to
4408bf3
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/add-support-for-updates
branch
2 times, most recently
from
January 18, 2024 21:28
4a34b7b
to
6321ed0
Compare
gabrieldonadel
changed the title
[menu-bar][cli] Add support for launching updates
[menu-bar][cli] Add basic support for launching Expo updates
Jan 19, 2024
gabrieldonadel
force-pushed
the
@gabrieldonadel/add-support-for-updates
branch
4 times, most recently
from
January 19, 2024 12:33
9561bb9
to
b60bb21
Compare
alanjhughes
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a few nits but totally up to you if you want to do anything about them or not
Co-authored-by: Alan Hughes <30924086+alanjhughes@users.noreply.github.com>
gabrieldonadel
force-pushed
the
@gabrieldonadel/add-support-for-updates
branch
from
January 19, 2024 19:56
493b36d
to
50ede8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Expo Updates are a big part of EAS and Orbit should be able to directly launch them into devices and simulators.
Closes ENG-11072
Closes #113
How
launch-update
commandEmulator.getRunningDeviceAsync
andSimulator.isSimulatorAsync
helper functionsOfficially supported formats
This PR adds basic support for launching Expo updates that use the following formats:
expo-orbit//update/u.expo.dev/:appId/channel/:channelId?platform=(android|ios)
expo-orbit//update/u.expo.dev/:appId/branch/:branchId?platform=(android|ios)
expo-orbit//update/u.expo.dev/:appId/group/:groupId?platform=(android|ios)
expo-orbit//update/u.expo.dev/:appId/update/:updateId?platform=(android|ios)
Note
As long as the URL specifies the “platform” in the query params Orbit should be able to launch any update.
Test Plan
Scenario 1 (An app that uses dev-client)
3.1. Most recent development build for that runtime version should be installed automatically
3.2. Update should be launched
Scenario 2 (An app that does not use dev-client)
runtimeVersion=exposdk:X.X.X
)2.1. Expo Go for that sdk should be installed automatically
2.2. Update should be launched