Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu-bar][cli] Add basic support for launching Expo updates #134

Merged
merged 12 commits into from
Jan 19, 2024

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Jan 12, 2024

Why

Expo Updates are a big part of EAS and Orbit should be able to directly launch them into devices and simulators.

Closes ENG-11072
Closes #113

How

  • Add new launch-update command
  • Add @expo/multipart-body-parser and expo-manifests dependencies
  • Add Emulator.getRunningDeviceAsync and Simulator.isSimulatorAsync helper functions
  • Refactor deeplink parsing on menu-bar

Officially supported formats

This PR adds basic support for launching Expo updates that use the following formats:

  • expo-orbit//update/u.expo.dev/:appId/channel/:channelId?platform=(android|ios)
  • expo-orbit//update/u.expo.dev/:appId/branch/:branchId?platform=(android|ios)
  • expo-orbit//update/u.expo.dev/:appId/group/:groupId?platform=(android|ios)
  • expo-orbit//update/u.expo.dev/:appId/update/:updateId?platform=(android|ios)

Note

As long as the URL specifies the “platform” in the query params Orbit should be able to launch any update.

Test Plan

Scenario 1 (An app that uses dev-client)

  1. Create development builds on EAS for Android and iOS
  2. Create a new update
  3. Launch Orbit using the update URL
    3.1. Most recent development build for that runtime version should be installed automatically
    3.2. Update should be launched

Scenario 2 (An app that does not use dev-client)

  1. Create a new update (runtimeVersion=exposdk:X.X.X)
  2. Launch Orbit using the update URL
    2.1. Expo Go for that sdk should be installed automatically
    2.2. Update should be launched

Copy link

linear bot commented Jan 12, 2024

@gabrieldonadel gabrieldonadel changed the base branch from main to @gabrieldonadel/cli-auth January 15, 2024 22:10
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/add-support-for-updates branch 3 times, most recently from c38c767 to 54de00c Compare January 16, 2024 23:39
@gabrieldonadel gabrieldonadel changed the base branch from @gabrieldonadel/cli-auth to @gabrieldonadel/add-graphql-to-cli January 16, 2024 23:40
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/add-support-for-updates branch 2 times, most recently from 9d91220 to 0b804e8 Compare January 16, 2024 23:49
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/add-graphql-to-cli branch from 5a483ef to 4408bf3 Compare January 18, 2024 13:37
Base automatically changed from @gabrieldonadel/add-graphql-to-cli to main January 18, 2024 15:21
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/add-support-for-updates branch 2 times, most recently from 4a34b7b to 6321ed0 Compare January 18, 2024 21:28
@gabrieldonadel gabrieldonadel changed the title [menu-bar][cli] Add support for launching updates [menu-bar][cli] Add basic support for launching Expo updates Jan 19, 2024
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/add-support-for-updates branch 4 times, most recently from 9561bb9 to b60bb21 Compare January 19, 2024 12:33
@gabrieldonadel gabrieldonadel marked this pull request as ready for review January 19, 2024 12:33
Copy link
Contributor

@alanjhughes alanjhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few nits but totally up to you if you want to do anything about them or not

apps/cli/src/commands/LaunchUpdate.ts Outdated Show resolved Hide resolved
apps/cli/src/commands/LaunchUpdate.ts Outdated Show resolved Hide resolved
apps/menu-bar/src/popover/Core.tsx Outdated Show resolved Hide resolved
apps/menu-bar/src/popover/Core.tsx Outdated Show resolved Hide resolved
apps/menu-bar/src/popover/Core.tsx Outdated Show resolved Hide resolved
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/add-support-for-updates branch from 493b36d to 50ede8e Compare January 19, 2024 19:56
@gabrieldonadel gabrieldonadel merged commit f154095 into main Jan 19, 2024
1 check passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/add-support-for-updates branch January 19, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Open a specific update or channel
2 participants