[cli] Update download function to cache builds #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
force-pushed
the
@gabrieldonadel/cache-downloads
branch
from
309cee3
to
5ea597d
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/cache-downloads
branch
from
5ea597d
to
4715c2c
Compare
alanjhughes
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In some cases, users might launch the same build multiple times through Orbit and there is not need to redownload the build file everytime
How
Update the download function to cache build downloads by default
Test Plan
Run
yarn cli download-build https://expo.dev/artifacts/eas/5QUw5J97RyQod9fxvGad5a.apk