Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu-bar] Add electron support for Checkbox component #161

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

gabrieldonadel
Copy link
Member

Why

The current Checkbox component does not show the label on the web

How

Refactor Checkbox component, move native part to a different file and add web implementation

Test Plan

Screen.Recording.2024-02-02.at.16.45.29.mov
Screen.Recording.2024-02-02.at.16.52.16.mov

@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-window-manager branch from 768582e to cee8796 Compare February 5, 2024 22:21
Base automatically changed from @gabrieldonadel/electron-window-manager to main February 5, 2024 22:26
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-checkbox branch from 09a31ba to 7471849 Compare February 5, 2024 23:18
@gabrieldonadel gabrieldonadel merged commit 40b2bcf into main Feb 6, 2024
1 check passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/electron-checkbox branch February 6, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants