[menu-bar] Fix Window height on electron #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
force-pushed
the
@gabrieldonadel/electron-window-manager-fix
branch
from
8baf111
to
670add2
Compare
Base automatically changed from
@gabrieldonadel/electron-platform-color
to
main
February 9, 2024 18:52
gabrieldonadel
force-pushed
the
@gabrieldonadel/electron-window-manager-fix
branch
from
992de2e
to
8346983
Compare
alanjhughes
approved these changes
Feb 9, 2024
gabrieldonadel
deleted the
@gabrieldonadel/electron-window-manager-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When using titlebarAppearsTransparent the window height does not match the window size on macOS
How
Add 30px to window height when
titlebarAppearsTransparent = trueTest Plan