[menu-bar][electron] Fix support for runCli env vars #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanjhughes
approved these changes
Feb 16, 2024
gabrieldonadel
commented
Feb 16, 2024
Comment on lines
+10
to
+17
| optimizeDeps: { | ||
| include: ['common-types'], | ||
| }, | ||
| build: { | ||
| commonjsOptions: { | ||
| include: [/common-types/, /node_modules/], | ||
| }, | ||
| }, |
There was a problem hiding this comment.
According to https://vitejs.dev/guide/dep-pre-bundling.html#monorepos-and-linked-dependencies
In a monorepo setup, a dependency may be a linked package from the same repo. Vite automatically detects dependencies that are not resolved from node_modules and treats the linked dep as source code. It will not attempt to bundle the linked dep, and will analyze the linked dep's dependency list instead.
However, this requires the linked dep to be exported as ESM. If not, you can add the dependency to optimizeDeps.include and build.commonjsOptions.include in your config.
gabrieldonadel
force-pushed
the
@gabrieldonadel/electron-env-vars
branch
from
6236a39
to
6ced301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Setting a custom Android SDK root location on electron crashes the app
How
Test Plan
Screen.Recording.2024-02-16.at.17.06.15.mov