Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu-bar][cli] Add support for launching updates with locally installed apps #188

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Mar 5, 2024

Why

We should allow users to launch updates using locally installed apps in case they don't have any available builds on EAS

How

  • Add --skip-install option to launch-update CLI command
  • Update launch-update CLI command to check if the local app is compatible with the update
  • Handle authentication issues

Test Plan

Screen.Recording.2024-03-05.at.13.04.01.mov

@gabrieldonadel gabrieldonadel marked this pull request as ready for review March 5, 2024 16:21
Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy tweaks

apps/menu-bar/src/popover/Core.tsx Outdated Show resolved Hide resolved
apps/menu-bar/src/popover/Core.tsx Outdated Show resolved Hide resolved
Co-authored-by: Brent Vatne <brentvatne@gmail.com>
@gabrieldonadel gabrieldonadel merged commit 957eaed into main Mar 6, 2024
1 check passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/improve-launching-updates branch March 6, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants