[menu-bar] Refactor SystemIconView to work when switching themes #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
deleted the
@gabrieldonadel/fix-system-icon-view-appearance
branch
|
FWIW, |
Ohh now things make more sense 😅 I remember that the SystemIconView component used to work a couple of months ago but for some reason it stopped working. Seems that it was related to the react-native-maps upgrade then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-10386
How
Refactor SystemIconView to no longer inherit from RCTImageView and use NSImageView directly. This way we can easily set the image as a template and change the view contentTintColor
Test Plan
Screen.Recording.2023-10-19.at.00.26.35.mov