[menu-bar] Fix user default preferences storage migration #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
deleted the
@gabrieldonadel/fix-user-preferences-storage-migration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When migrating from v0.1.3 to latest default user preferences are not applied, causing the user to see no simulators/emulators in the menu bar
How
Update
getUserPreferencesto merge the retrieved object from mmkv with the default preferences, this ensures that in case we add new keys toUserPreferencesgetUserPreferenceswill always return the whole object with the default valuesTest Plan
Run Android emulator without audio)