Update devInternalSettings #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudo
approved these changes
Oct 15, 2024
|
@Kudo I've fixed it and added it to my android PR for the expo go migration. |
makes sense. in this case, maybe we can edit in-place and drop the ReactAndroidCodeTransformer. let's discuss this in sdk sync. |
gabrieldonadel
force-pushed
the
sdk-52
branch
from
6271e6b
to
388dbe8
Compare
alanjhughes
force-pushed
the
@alanhughes/fix-code-transformer
branch
from
35bbb95
to
388dbe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
ReactAndroidCodeTransformerdid not make the necessary modifications during the RN upgrade.