Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused devDependency methods #548

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Remove unused devDependency methods #548

merged 1 commit into from
Oct 22, 2024

Conversation

Phillip9587
Copy link
Contributor

This PR removes the unused methods package from devDependencies. After reviewing the codebase, i think that methods is no longer required or used anywhere in the project.

UlisesGascon
UlisesGascon approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, seems like we are no longer use methods. So we can remove it 👍

@UlisesGascon UlisesGascon merged commit 1aad750 into expressjs:master Oct 22, 2024
4 checks passed
@UlisesGascon UlisesGascon mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phillip9587 @UlisesGascon