Remove res.jsonp(status, obj) signature #2940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,6 +25,7 @@ This is the first Express 5.0 alpha release, based off 4.10.1. | |||
| - `req.acceptsLanguage` - use `req.acceptsLanguages` | |||
| - `res.json(obj, status)` signature - use `res.json(status, obj)` | |||
| - `res.jsonp(obj, status)` signature - use `res.jsonp(status, obj)` | |||
There was a problem hiding this comment.
should this existing line be rewritten to:
- `res.jsonp(obj, status)` signature - use `res.status(status).jsonp(obj)`
?
There was a problem hiding this comment.
No, because that is the change log for the first alpha. You can't changed what has already been released.
tunniclm
force-pushed
the
remove_deprecated_res_jsonp_status_obj_sig
branch
from
03eb2da to
37c8352
Compare
|
Fixed the History.md mistake. |
tunniclm
force-pushed
the
remove_deprecated_res_jsonp_status_obj_sig
branch
from
37c8352 to
05c9a5a
Compare
|
Updated due to comments on similar pull request (#2939) |
|
@tunniclm coverage has decreased by a fraction, otherwise looks good to me. |
|
As mentioned in the other similar pull request (see #2939 (comment)), the slight reduction in coverage is due to the reduced number of lines in the changed file (response.js). |
tunniclm
force-pushed
the
remove_deprecated_res_jsonp_status_obj_sig
branch
from
05c9a5a to
2f2c636
Compare
dougwilson
pushed a commit
that referenced
this pull request
Jan 29, 2017
|
Merged into the 5.0 branch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.