Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw TypeError if argument passed to res.status is null or undefined #3111

Closed
wants to merge 2 commits into from
Closed

Throw TypeError if argument passed to res.status is null or undefined #3111

wants to merge 2 commits into from

Conversation

Shastel
Copy link

@Shastel Shastel commented Oct 26, 2016

It's fix for #2795

@dougwilson
Copy link
Contributor

Hi @Shastel , thanks for the pull request! I see in the issue you linked, it was said that #2797 is made to fix that issue. Is this pull request a duplicate of #2797 ? If not, in what ways does it differ?

@dougwilson dougwilson added the pr label Oct 26, 2016
@dougwilson dougwilson self-assigned this Oct 26, 2016
@Shastel
Copy link
Author

Shastel commented Oct 26, 2016

Hi @dougwilson, It's not a duplicate, but generally it's almost same as #2797 . But that pr has not any progress almost year

@dougwilson
Copy link
Contributor

Hi @Shastel, that PR is just pending merge into 5.x. Unless there is something you feel is wrong with it, we have full intention on merging that into 5.x. I do appreciate you making the pull request, but I don't want to disregard that user's PR and instead use this one unless there is something different about this one.

@dougwilson
Copy link
Contributor

To summarize, I can use this one over the other, but I wasn't aware of anything wrong with the other. If it's not a duplicate and there is something different, please explain the differences so we can understand which one to accept. Otherwise, we'll default to the one that came first is all I'm saying.

@Shastel
Copy link
Author

Shastel commented Oct 26, 2016

My pr hasn't unnecessary else statement.
And also we also should ask @joshuacaron about any progress

@dougwilson
Copy link
Contributor

And also we also should ask @joshuacaron about any progress

Progress of what?

@Shastel
Copy link
Author

Shastel commented Oct 26, 2016

@dougwilson sorry, i have misunderstanding with flow.
So if from yours point of view difference between pr's is not critical we should close my pr.

@dougwilson
Copy link
Contributor

I can use this one over the other, but I wasn't aware of anything wrong with the other. If it's not a duplicate and there is something different, please explain the differences so we can understand which one to accept. Otherwise, we'll default to the one that came first is all I'm saying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants