-
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw TypeError if argument passed to res.status is null or undefined #3111
Conversation
Hi @dougwilson, It's not a duplicate, but generally it's almost same as #2797 . But that pr has not any progress almost year |
Hi @Shastel, that PR is just pending merge into 5.x. Unless there is something you feel is wrong with it, we have full intention on merging that into 5.x. I do appreciate you making the pull request, but I don't want to disregard that user's PR and instead use this one unless there is something different about this one. |
To summarize, I can use this one over the other, but I wasn't aware of anything wrong with the other. If it's not a duplicate and there is something different, please explain the differences so we can understand which one to accept. Otherwise, we'll default to the one that came first is all I'm saying. |
My pr hasn't unnecessary |
Progress of what? |
@dougwilson sorry, i have misunderstanding with flow. |
I can use this one over the other, but I wasn't aware of anything wrong with the other. If it's not a duplicate and there is something different, please explain the differences so we can understand which one to accept. Otherwise, we'll default to the one that came first is all I'm saying. |
It's fix for #2795