Fix response headers usage with upcoming node changes #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougwilson
reviewed
Jan 14, 2017
| // Support changes in node with how response headers are stored | ||
| var headerNames = this.res._headerNames || {}; | ||
| var keys = Object.keys(resHeaders); | ||
| if (keys.length > 0 && headerNames[keys[0]] === undefined) { |
There was a problem hiding this comment.
There are a whole lot of Node.js http mock libraries out there (https://github.com/howardabrams/node-mocks-http comes to mind) and they have never mocked the _headerNames object. I think this would cause the usage of those modules to change the behavior (probably break) people's tests for Express projects that use them since this code would detect those mocks as the new style of headers and then copy all the header values as undefined, right?
|
I just landed the change that landed in the |
dougwilson
added a commit
that referenced
this pull request
Feb 21, 2017
|
Closing this as now more public API methods exist and there is now a docs-only deprecation of the private properties/methods. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.