Better error handling for sendFile #3582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougwilson
suggested changes
Mar 4, 2018
dougwilson
reviewed
Mar 4, 2018
lib/response.js
Outdated
| if (!path) { | ||
| throw new TypeError('path argument is required to res.sendFile'); | ||
| if (typeof path !== 'string') { | ||
| throw new TypeError('path must be string'); |
There was a problem hiding this comment.
Also, can you add back res.sendFile to the message? Helps people know what function the issue was to.
|
if you pass something other than valid string like sendFile({}) you get: TypeError: path.substring is not a function. which is kind of confusing, so instead now you getting: path must be string |
|
Makes sense. Just add a test for that so we have it there to not regress from a refactor 👍 |
|
@dougwilson all test are passing on my system |
|
The build failures seemed unrelated, I restarted the two failed builds... |
dougwilson
approved these changes
Oct 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so you don't get confusing errors like: function substring not found or something