Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove nodejs 9 in nightly #3617

Merged
merged 1 commit into from
Oct 27, 2018
Merged

remove nodejs 9 in nightly #3617

merged 1 commit into from
Oct 27, 2018

Conversation

nacimgoura
Copy link
Contributor

NodeJS 9 is no longer nightly. This is the current non-LTS version of nodejs.

Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please add the current minor version number to the entry and also update appveyor config :)

@dougwilson
Copy link
Contributor

Oops, looks like 9.11 is not available on appveyor. Can you get appveyor and travis to a lower version that is available on both?

@nacimgoura
Copy link
Contributor Author

nacimgoura commented Apr 10, 2018

Even for travis? Even if it's good with the latest version? The versions on travis and appveryor must be the same?

The last version supported by nodejs 9 is 9.8

@dougwilson
Copy link
Contributor

Yea

@nacimgoura
Copy link
Contributor Author

It's done!

@nacimgoura nacimgoura changed the title remove nodejs 9 in nightly - travis.yml remove nodejs 9 in nightly Apr 10, 2018
@dougwilson dougwilson added this to the 4.17 milestone Sep 24, 2018
@dougwilson dougwilson mentioned this pull request Oct 27, 2018
23 tasks
@dougwilson dougwilson changed the base branch from master to 4.17 October 27, 2018 03:41
@dougwilson dougwilson merged commit 003459b into expressjs:4.17 Oct 27, 2018
dougwilson pushed a commit to felixbuenemann/express that referenced this pull request Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants