Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot #5435

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Feb 2, 2024

Main Changes

The dependabot will check for available updates for the dependencies that we use in the project. In the current setup it will generate PRs once per week if the are new versions for our dependencies (npm and Github Actions).

We can remove npm and limit it to Github Actions, as well we can modify the frequency.

The dependabot is capable of follow the pin version schema introduced in #5432, so it will be able to upgrade and pin the GIthub actions accordantly.

The configuration is very flexible, see the documentation

Context

Changelog

@UlisesGascon UlisesGascon marked this pull request as ready for review February 2, 2024 16:28
@shivam-sharma7
Copy link

shivam-sharma7 commented Feb 9, 2024

@UlisesGascon you can also set pull request limit and timezone, that would be nice!

@UlisesGascon
Copy link
Member Author

@UlisesGascon you can also set pull request limit and timezone, that would be nice!

Feel free to add a suggestion in the PR directly @shivam-sharma7 👍

Co-authored-by: Shivam Sharma <meshivam81@gmail.com>
Copy link

@shivam-sharma7 shivam-sharma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wesleytodd
Copy link
Member

Hey, I just wanted to drop a note in here (I haven't had time to review yet) but we had talked about different approaches to dependency updates for express in the past and this approach does not align with the previous decisions on how we should do this. Once we get a regular cadence of meetings going and get over the hump of kicking everything back off I think we should address this, but I believe that it will take some discussion and alignment. Just didn't want folks to get frustrated if this sat for a while without clarity.

Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGascon UlisesGascon added the semver-ignore This change does not have any impact in semver (docs, tooling, etc..) label Apr 17, 2024
@krzysdz krzysdz mentioned this pull request Sep 11, 2024
@Patricia0507

This comment was marked as off-topic.

@wesleytodd
Copy link
Member

Discussed on our security call just now. We proposed (and agreed to on the call) to only update github actions with dependabot. Additionally we discussed that folks need to be careful about merging those, especially when updating third party community actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps pr semver-ignore This change does not have any impact in semver (docs, tooling, etc..) tc agenda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants