Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace 'path-is-absolute' dep with node:path isAbsolute method #5830

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

carpasse
Copy link
Contributor

Related discussion expressjs/discussions#256

@carpasse
Copy link
Contributor Author

@wesleytodd path.isAbsolute method was added in Node.js 0.11.2, which means that, in theory, this commit introduces a breaking change. According to this discussion, we are expected to clearly mark such changes in our commits.

Should I mark this as a breaking change using the Conventional Commits BREAKING CHANGE convention?

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I would like to get us to using CC, nothing is today so we are not enforcing any commit style at this time.

We refactored the v5 branch to still test in old node versions as optional checks but have already merged changes which break before node 6 IIRC. So this should not block anything.

As for this, if you could add this to the history file under unreleased changes that would be awesome. Not a big deal, but I forgot to ask for it on a few commits and so am trying to remember.

@wesleytodd wesleytodd merged commit 0983158 into expressjs:5.0 Aug 17, 2024
12 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants