Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update homepage link http to https #5920

Merged
merged 2 commits into from
Oct 20, 2024
Merged

update homepage link http to https #5920

merged 2 commits into from
Oct 20, 2024

Conversation

bjohansebas
Copy link
Member

It would be good to use HTTPS for the homepage link.

UlisesGascon
UlisesGascon approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @bjohansebas!

@bjohansebas
Copy link
Member Author

Should I update the branch?

@wesleytodd
Copy link
Member

You can, but until we merge 5.x we are frozen on master anyway. I just have not been able to get to it today with dentists appts and work stuff.

@bjohansebas bjohansebas changed the base branch from 5.0 to master September 11, 2024 21:54
@UlisesGascon
Copy link
Member

condition meet, I will merge the PR

@UlisesGascon UlisesGascon merged commit b274047 into expressjs:master Oct 20, 2024
21 checks passed
@bjohansebas bjohansebas deleted the use-https branch October 20, 2024 19:09
@UlisesGascon UlisesGascon mentioned this pull request Oct 29, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IamLizu IamLizu IamLizu approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@wesleytodd wesleytodd wesleytodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bjohansebas @wesleytodd @UlisesGascon @IamLizu