Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readme #5994

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Improve readme #5994

merged 1 commit into from
Oct 20, 2024

Conversation

bjohansebas
Copy link
Member

Changes

  • The appveyor reference is removed.
  • The $ sign has been removed from each command, it was inconvenient to have to remove that character every time it was copied.
  • Some community resources are removed, and discussions are added as part of the community.

UlisesGascon
UlisesGascon approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjohansebas!

IamLizu
IamLizu reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@IamLizu IamLizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am generally okay with this but I would prefer not to change function syntax yet. Also, script declaration changes from console to bash as well.

@UlisesGascon UlisesGascon merged commit 508c740 into expressjs:master Oct 20, 2024
2 checks passed
@bjohansebas bjohansebas deleted the update-readme-v5 branch October 20, 2024 19:07
@UlisesGascon UlisesGascon mentioned this pull request Oct 29, 2024
Draft
newkdr added a commit to newkdr/express that referenced this pull request Dec 8, 2024
@newkdr
Revert "docs: update readme (expressjs#5994)"
f947dbd 
This reverts commit 508c740.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IamLizu IamLizu IamLizu left review comments

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@carpasse carpasse carpasse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bjohansebas @carpasse @UlisesGascon @IamLizu