fix(buffer): use node:buffer instead of safe-buffer #6071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleytodd
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
The only thing I would say is this is not a "chore" commit. It is a fix or feat (honestly in this case I could see it going either way) and also the "scope" section here is not really necessary. Not a big deal since we don't really enforce the conventional commit conventions anyway, but just figured I would drop this note with the approval in case you wanted to edit it before we merge.
bhavya3024
changed the title
bjohansebas
approved these changes
Oct 17, 2024
UlisesGascon
approved these changes
Oct 27, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wesleytodd
Since express@5 will support minimum of nodejs version 18, I think it would be safe to use
node:buffer.Also I didn't see any
new Bufferusage anywhere in their repo.