Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Object.setPrototypeOf polyfill #6081

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Phillip9587
Copy link
Contributor

This PR removes the Object.setPrototypeOf polyfill, which is no longer needed since Express now requires Node.js v18 as the minimum supported version. All existing tests should pass, as this change only impacts older Node versions no longer supported.

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this PR @Phillip9587!

@UlisesGascon UlisesGascon self-assigned this Oct 21, 2024
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this change be reflected in the history?

@Phillip9587 Phillip9587 force-pushed the remove-setprototypeof branch from 86f999e to bcab127 Compare October 22, 2024 07:47
@UlisesGascon UlisesGascon merged commit 8cb53ea into expressjs:master Oct 22, 2024
21 checks passed
@UlisesGascon UlisesGascon mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants