Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: list website committers #6087

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Oct 26, 2024

This PR formalizes the committers for the website proposed in #6057.

I am +1 in the nomination

@bjohansebas bjohansebas requested a review from a team October 26, 2024 20:20
@UlisesGascon
Copy link
Member

cc: @expressjs/docs-captains @expressjs/express-tc

@bjohansebas
Copy link
Member Author

ping

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have raised this before, but I think we should move this all out of the express repo. We want to onboard a bunch more folks, and we should not need to dirty up the express history for this.

It was acceptable since thats where it started for the captians, but I am concerned this new addition is unmaintainable across the packages.

Could we instead open an RFC in the discussions repo for better ways to highlight contributors? If we can get the status board updated and maybe work toward integrating to the LFX dashboard, we could have a zero-maitenence way in the future. That would be much more ideal than this imo.

Copy link
Member

@ctcpip ctcpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very supportive of documenting and giving credit to all contributors, but this is not the place for it. Let's move forward with Wes's suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants