Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use loop for acceptParams (4.x backport) #6176

Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from

Conversation

jonchurch
Copy link
Member

@jonchurch jonchurch commented Nov 14, 2024

cherry-pick #6066 into 4.x

#6066 (comment)

@UlisesGascon: Should we also backport it to v4?

Not worth a release on its own, but when it's as easy a cherry-pick and no other changes, hard not to backport.

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is annoying, but we should continue checking to ensure the history file is updated until we can automate it. That should have been done in the original as well, but too late now.

@jonchurch
Copy link
Member Author

jonchurch commented Nov 14, 2024

I thought about updating the history file. But there's no API or dep change, and no one requested the change after 1 month of it sitting open

@jonchurch jonchurch force-pushed the jonchurch/4.x-accept-params-loop branch from 044d0a9 to 585a3f1 Compare November 14, 2024 21:15
@wesleytodd
Copy link
Member

Sure, but it is "the process". We absolutely should change the process, but until we do it is easy to add and ensures folks doing the release dont forget anything.

@jonchurch
Copy link
Member Author

jonchurch commented Nov 14, 2024

pr for it incoming

edit: #6177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants