Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace methods dependency with standard library #6196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonkoops
Copy link

@jonkoops jonkoops commented Dec 2, 2024

Replaces the methods dependency with calls to the standard library of Node.js. Since methods is mostly a polyfill for require('node:http').METHODS in older versions of Node.js that are no longer supported this can be removed.

Works towards closing #4282

Signed-off-by: Jon Koops <jonkoops@gmail.com>
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we no longer support Node.js versions earlier than 18, we can proceed with this!

+1

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants