Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes expressjs/multer#553 . Makes multer handle missing field names. #913

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

ZloeSabo
Copy link
Contributor

Without this fix fields without a name result in a "TypeError: Cannot read property 'length' of undefined"
in the underlying append-field library.

The current change allows getting an error from multer that makes it
possible to handle it in servers.

See #553

Without this fix fields without a name result in a "TypeError: Cannot read property 'length' of undefined"
in the underlying append-field library.

The current change allows getting an error from multer that makes it
possible to handle it in servers.
@ZloeSabo ZloeSabo force-pushed the fix/handle-missing-field-name branch from c1ad9bb to 97d3867 Compare June 29, 2020 19:32
@lukebickell
Copy link

Any way to get that PR merged? Seeing this issue with our NestJS services :(

@faust64
Copy link

faust64 commented May 25, 2021

Same here, though I first went with patching busboy:

https://github.com/mscdex/busboy/pull/244/files

I hesitated doing something similar in multer instead. That PR looks exactly like what I was looking for.

@faust64
Copy link

faust64 commented Sep 12, 2021

Any news?
@LinusU ? I see you've been pushing changes lately: any chance you could look at this?

lib/make-middleware.js Outdated Show resolved Hide resolved
lib/multer-error.js Outdated Show resolved Hide resolved
test/error-handling.js Outdated Show resolved Hide resolved
@LinusU LinusU merged commit 055767b into expressjs:master Dec 7, 2021
@LinusU
Copy link
Member

LinusU commented Dec 7, 2021

Sorry for the very slow reply on this!

Released as 1.4.4 🚀

nevilm-lt pushed a commit to nevilm-lt/multer that referenced this pull request Apr 21, 2022
Fixes expressjs#553

Without this fix fields without a name result in a "TypeError: Cannot read property 'length' of undefined" in the underlying append-field library.

The current change allows getting an error from Multer that makes it possible to handle it in servers.

Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
nevilm-lt pushed a commit to nevilm-lt/multer that referenced this pull request Apr 22, 2022
Fixes expressjs#553

Without this fix fields without a name result in a "TypeError: Cannot read property 'length' of undefined" in the underlying append-field library.

The current change allows getting an error from Multer that makes it possible to handle it in servers.

Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
nevilm-lt pushed a commit to nevilm-lt/multer that referenced this pull request Apr 22, 2022
Fixes expressjs#553

Without this fix fields without a name result in a "TypeError: Cannot read property 'length' of undefined" in the underlying append-field library.

The current change allows getting an error from Multer that makes it possible to handle it in servers.

Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
himanshiLt pushed a commit to himanshiLt/multer that referenced this pull request Apr 26, 2022
Fixes expressjs#553

Without this fix fields without a name result in a "TypeError: Cannot read property 'length' of undefined" in the underlying append-field library.

The current change allows getting an error from Multer that makes it possible to handle it in servers.

Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants