Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fallthrough option #61

Closed
wants to merge 1 commit into from
Closed

Add fallthrough option #61

wants to merge 1 commit into from

Conversation

nidorx
Copy link

@nidorx nidorx commented Feb 19, 2017

dougwilson
dougwilson suggested changes Feb 19, 2017
View reviewed changes
Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks like there are two major issues:

  1. There are no tests
  2. The added documentation describe something very different than the implementation you made

@dougwilson dougwilson self-assigned this Feb 19, 2017
@dougwilson dougwilson mentioned this pull request May 4, 2018
Closed
@dougwilson
Copy link
Contributor

Closing due to no response.

@dougwilson dougwilson closed this Aug 11, 2018
@iamandrewluca iamandrewluca mentioned this pull request Dec 26, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougwilson dougwilson dougwilson requested changes

Assignees

@dougwilson dougwilson

Labels
needs docs needs tests pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nidorx @dougwilson