Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude "non-API" defined in R's source code #132

Closed
yutannihilation opened this issue Feb 19, 2023 · 1 comment · Fixed by #135
Closed

Exclude "non-API" defined in R's source code #132

yutannihilation opened this issue Feb 19, 2023 · 1 comment · Fixed by #135

Comments

@yutannihilation
Copy link
Contributor

yutannihilation commented Feb 19, 2023 •
edited
Loading

We can blocklist these symbols to prevent them from being misused. Note that, some of them are actually used in extendr-engine, so we need to exclude these from the exclusion.

https://github.com/wch/r-source/blob/8791c1706307083bc2f188a6b24fda1b5ef03cdf/src/library/tools/R/sotools.R#L376-L480
@yutannihilation yutannihilation changed the title Exclude "non-API defined in Exclude "non-API" defined in R's source code Feb 19, 2023
@yutannihilation
Copy link
Contributor Author

extendr-engine requires:

  • R_CStackLimit
  • R_CleanTempDir
  • R_RunExitFinalizers
  • Rf_endEmbeddedR
  • Rf_initialize_R
  • setup_Rmainloop

https://gist.github.com/yutannihilation/3fa914926df4ea7106cd972cd6b4f104#2-list-up-non-apis-used-in-extendr

@yutannihilation yutannihilation mentioned this issue Feb 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude non-API calls yutannihilation/libR-sys
1 participant
@yutannihilation