Exclude non-API calls #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/bindings |
|
I updated the branch using my forked repo: yutannihilation#15 |
|
Hmm, strange. |
Oh, Intel mac seems to keep failing...
Anyway, I realize checking these list eagerly is unstable and not a good idea. I'll move it to a separate action just for updating nonAPI.txt. |
…tannihilation/libR-sys into refactor/remove-non-API-calls
|
/bindings |
|
Okay, sorry for being noisy. This should be ready now, but I don't want to merge this before publishing v0.4.0. Adding APIs should be safe, but removing might not. I'll write the summary in description, but in short,
|
CGMossa
approved these changes
Feb 26, 2023
|
Thanks.
To prevent tragedy like extendr/extendr#424 |
|
/bindings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #132
The main change of this pull request is preventing the "non-API" calls from being included in the
allowlist. These "non-API" are APIs that are available but prohibited to use. What does "prohibited" mean? It meansR CMD checkwarns, so a package using extendr won't be accepted by CRAN. So, it's better not to expose them.To be clear, (except that there's no guarantee that these APIs can get changed without any announcement) it's not a problem as long as the user doesn't have the ambition to submit their R package to CRAN. Actually, the extendr-engine crate some of these. So we have to keep them exported.
The list of "non-API" symbols can be found in
tools:::nonAPI. To avoid complexity, this is dumped to a text filenonAPI.txtoutside ofbuild.rs, and periodically updated by the GitHub Actions CI; when there's any change on the list, the CI automatically creates a pull request like this: yutannihilation#19.