Redefine R-devel's Rcomplex

[CGMossa]

Instead of fighting everything, we can just provide functions that help us manipulate Rcomplex through C99 / C11.

Depends on:

• [PoC] Test against the generated bindings #157 to pass CI.

[CGMossa]

/bindings

[CGMossa]

/bindings

[CGMossa]

@yutannihilation do you know how I could solve this? I need the generated bindings before this can pass ci.

[yutannihilation]

I can't see what's happening here... Do you mean you can generate bindings on your local?

I guess you have to add create_rcomplex (and other functions as well?) to allowlist.

[CGMossa]

If I run cargo build --features use-bindgen first, then a bindings are generated, and then calls like cargo test work without a problem.

[CGMossa]

/bindings

[yutannihilation]

Then, I have no idea. I might have time to look into at night, sorry.

[CGMossa]

Yeah no problem. I wouldn't ask for more. Thanks for attempting to solve it quickly.

[yutannihilation]

Sorry, now I understand what you meant. I think the current CI setup is wrong. This says "Run tests on precomputed bindings shipped with libR-sys," but I guess the intent of this is to test against the new bindings generated on the previous step. This is probably my mistake when I tweaked the settings to upload the bindings as artifacts.

libR-sys/.github/workflows/test.yml

Lines 247 to 260 in df48d39

	# Run tests again using different bindings
	- name: Run tests on precomputed bindings shipped with libR-sys
	run: |
	. ./ci-cargo.ps1
	foreach ($target in ($env:RUST_TARGETS).Split(",")) {
	if(($env:NO_TEST_TARGETS).Split(",").Contains($target)) {
	echo "::warning:: Skipping tests for target: $target"
	}
	else {
	ci-cargo test -vv $(if ($target -ne 'default') {"--target=$target"} ) '--' --nocapture --test-threads=1 -ActionName "Running tests for target: $target"
	}
	}
	env:
	NO_TEST_TARGETS: ${{ join(matrix.config.no-test-targets, ',') }}

[CGMossa]

Repurposing this pull-request. @Ilia-Kosenkov suggested a replacement in the wrapper. On my end, it looks like it works. Thus I'll push that. Hopefully CI will be sorted and this can be reviewed+merged soon.

[CGMossa]

/bindings

[CGMossa]

CI passes because now we aren't really requiring much from it. The changes @yutannihilation mentioned still need to happen.

This works on ExtendR locally, but it needs to be merged for us to know.

I could add tests to this. They should atleast include an array test for this.

[CGMossa]

/bindings

[CGMossa]

/bindings

[Ilia-Kosenkov]

LGTM. The conflicts are due to the new version of R-devel, so just accept whatever changes your PR introduces over existing files.

[yutannihilation]

Oh, oldrel is already switched to R 4.2, which means it will never pass until we update the CI setting. You can ignore the CI failure for now.

[yutannihilation]

I'd like to regenerate the bindings on master to slide the version, so let me merge this before that.