Use rust constants and rust types in bindgen #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bindgen. This is a clippy-complaint as well.
|
This is also blocked by #157 |
|
/bindings |
|
Thanks for catching. I think we can just block them. Are there any good reason to re-export these constants that are already available via std? |
|
Maybe extendr uses the rust name? |
I quickly searched |
|
That's even better. I'll make adjustments. |
|
I've removed them. |
|
We could consider |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuing the effort to clean-up and smooth out libR-sys, I have found that clippy complains about these constants, and we can replace c-types with rust types by this setting.
This will need to be checked more thoroughly with extendr though.