Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bindings #182

Merged
merged 15 commits into from
Oct 4, 2023
Merged

Update bindings #182

merged 15 commits into from
Oct 4, 2023

Conversation

yutannihilation
Copy link
Contributor

This pull request is to reflect the removal of BLAS-releated functions in R-devel. This should have no problem.

R News:

Headers ‘R_ext/Applic.h’ and ‘R-ext/Linpack.h’ used to include ‘R_ext/BLAS.h’ although this was undocumented and unneeded by their documented entry points. They no longer do so.

CGMossa
CGMossa approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@CGMossa CGMossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the news, and I think it should just be updated. I like the massive reduction on the bindings..

LGTM

@yutannihilation yutannihilation merged commit 896d4c3 into master Oct 4, 2023
@yutannihilation yutannihilation deleted the generated_bindings branch October 4, 2023 11:31
@yutannihilation
Copy link
Contributor Author

Thanks!

@yutannihilation yutannihilation mentioned this pull request Nov 12, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGMossa CGMossa CGMossa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yutannihilation @CGMossa