Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove layout tests #196

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Remove layout tests #196

merged 5 commits into from
Nov 13, 2023

Conversation

CGMossa
Copy link
Member

@CGMossa CGMossa commented Nov 12, 2023

Remove these auto-generated layout tests. I don't think they have ever caught anything or helped with something. They could be plugged back in, if we refactor the generation of bindings with xtask-approach.

@CGMossa
Copy link
Member Author

CGMossa commented Nov 12, 2023

/bindings

@CGMossa
Copy link
Member Author

CGMossa commented Nov 12, 2023

This takes /bindings folder from 2.8 MB to 2.2MB.

build.rs Outdated Show resolved Hide resolved
and adjusted CI to test with layouts,
and then to save without layout tests
@CGMossa
Copy link
Member Author

CGMossa commented Nov 12, 2023

/bindings

@CGMossa CGMossa mentioned this pull request Nov 12, 2023
2 tasks
Copy link
Contributor

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@CGMossa CGMossa merged commit 6fc2b5f into master Nov 13, 2023
18 checks passed
@CGMossa CGMossa deleted the remove_layout_tests branch November 13, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants