Fix bindings failure on PRs #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 17, 2023
JosiahParry
reviewed
Nov 17, 2023
JosiahParry
reviewed
Nov 17, 2023
|
I have an issue now that it is running the workflow that pushes the bindings every time anything is run. |
CGMossa
force-pushed
the
add_generate_bindings_ci_command
branch
3 times, most recently
from
5c5634c to
de58a1c
Compare
This was referenced Nov 17, 2023
CGMossa
force-pushed
the
add_generate_bindings_ci_command
branch
from
1bae8e7 to
feffdbe
Compare
1 task
|
This is fixed now, and I've rebased it to remove all the annoying commits. |
CGMossa
requested review from
JosiahParry and
Ilia-Kosenkov
and removed request for
JosiahParry
Update maintainer guide hopefully, a GHA commit shouldn't follow maybe it needs to be an expression? what's happening... please xplain. right sha.. hopefully, a GHA commit shouldn't follow hopefully, a GHA commit shouldn't follow no generating of anything
Co-authored-by: Ilia Kosenkov <ilia.kosenkov@outlook.com>
CGMossa
force-pushed
the
add_generate_bindings_ci_command
branch
from
c305729 to
a407f6b
Compare
Ilia-Kosenkov
approved these changes
Apr 21, 2024
CGMossa
added a commit
that referenced
this pull request
Apr 21, 2024
* Added `[generate bindings]` command for CI Update maintainer guide * Update bindings [skip ci] * Update MAINTAINERS_GUIDE.md Co-authored-by: Ilia Kosenkov <ilia.kosenkov@outlook.com> --------- Co-authored-by: CGMossa <CGMossa@users.noreply.github.com> Co-authored-by: Ilia Kosenkov <ilia.kosenkov@outlook.com>
CGMossa
added a commit
that referenced
this pull request
Apr 21, 2024
* Added `[generate bindings]` command for CI Update maintainer guide * Update bindings [skip ci] * Update MAINTAINERS_GUIDE.md Co-authored-by: Ilia Kosenkov <ilia.kosenkov@outlook.com> --------- Co-authored-by: CGMossa <CGMossa@users.noreply.github.com> Co-authored-by: Ilia Kosenkov <ilia.kosenkov@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not an implementation of #204.
Currently, PRs that change
libR-syscannot pass CI checks.CI workflow right now: Runs checks + layout-tests. Uploads generated bindings (to other workflows). Then runs tests on precomputed bindings (that aren't "in" at the moment). This fails, because the generated bindings are not the precomputed bindings, the precomputed bindings are the ones from
main/master.Example of PRs that can't pass CI, even if the PR passes tests, are #206 and #205.
What this PR does is add a procedure that would commit the generated bindings, resulting from running CI, when the last commit message contains
[generate bindings].