Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo:warning to notify users during build time #215

Merged

Conversation

Ilia-Kosenkov
Copy link
Member

  • Use cargo:warning=Warning text to properly notify users (regular pirntln!() do not really work)
  • Put some dead code behind cfg (used only for bindgen)
    image

Copy link
Member

@CGMossa CGMossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please address the comment I have before merging though.. Approving because why not..

build.rs Outdated Show resolved Hide resolved
@Ilia-Kosenkov Ilia-Kosenkov merged commit 1ee216f into extendr:master Jan 7, 2024
18 checks passed
CGMossa pushed a commit to CGMossa/libR-sys that referenced this pull request Jan 21, 2024
* Use cargo warning

* Put bindgen-specific code behind a feature guard

* Revert back debug info
CGMossa pushed a commit that referenced this pull request Apr 21, 2024
* Use cargo warning

* Put bindgen-specific code behind a feature guard

* Revert back debug info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants