Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Rtools44 #220 #221

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Conversation

CGMossa
Copy link
Member

@CGMossa CGMossa commented Mar 23, 2024

fix #220

R-devel is now using Rtools44 as default.
We are seeing failure on extendr with r-devel, and it is resolved by this.

The failure is not seen on this repository though.

Once it is merged here, an equivalent correction should happen on extendr-repo.

@CGMossa
Copy link
Member Author

CGMossa commented Mar 23, 2024

We could also consider using this

$mingw_root = "C:\rtools$($env:RTOOLS_VERSION)\x86_64-w64-mingw32.static.posix"

@CGMossa CGMossa requested a review from JosiahParry March 23, 2024 11:35
@CGMossa CGMossa force-pushed the update_test_rtools44 branch from 8e8d5a4 to b814262 Compare March 23, 2024 11:57
@JosiahParry
Copy link

This PR changes to use Rtools 44 for devel r-devel. Green lights and looks good to me!

@JosiahParry JosiahParry merged commit fbeceb5 into extendr:master Mar 23, 2024
18 checks passed
@CGMossa CGMossa deleted the update_test_rtools44 branch March 23, 2024 19:03
CGMossa added a commit that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rtools44
2 participants