Conversions between bool and Rboolean
#230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing for arbitrary reason:
|
|
@Ilia-Kosenkov Honestly, I can't find a good way to eliminate this. I believe we should just redefine |
|
No-one merge please. I need to generate bindings first. |
|
Oldrel is 4.3 and so is release (4.3). R4.4 was released today. We must await the re-shuffling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many places where
boolandRbooleanare used and converted to and from each other inextendr-api.This is an immediate convenience (safe) conversion that I think we should adopt.
There is a more controversial one, which is
From<u32>, that I will propose after this one.