Finding all the rtools.. #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/bindings |
1 similar comment
|
/bindings |
Ilia-Kosenkov
approved these changes
Apr 26, 2024
Co-authored-by: Ilia Kosenkov <ilia.kosenkov@outlook.com>
|
/bindings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is Rtools for ARM, and Rtools for 4.4 that is added here.
I'd like to recap what is new here: Before, we specified the Rtools version manually for each new release, as we had to write which rtools version in the
matrix.config. Instead now, we rely fully on setup-r and the version of Rtools it wants to use (they are tied to R versions now), and we greedily try to detect which rtools path is available.This means that the list has to be updated manually now
This is still an improvement, because with Windows ARM, the path is a little different than the
pattern that we observed before.
What we ought to do is either extract the rtools path from
PATH, or scan for which path is present with R tools in it.Neither R, not setup-r gives these rtools_soft paths, and thus we cannot exploit their configuration strategies.