Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nonAPI.txt #236

Merged
merged 3 commits into from
May 9, 2024
Merged

Update nonAPI.txt #236

merged 3 commits into from
May 9, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 9, 2024

Please review the diff and run /bindings command manually.

@CGMossa
Copy link
Member

CGMossa commented May 9, 2024

I couldn't believe the generated results of #227, but it is true. We've lost the majority of the AltRep API.

@CGMossa CGMossa merged commit 1fa9052 into master May 9, 2024
@CGMossa CGMossa deleted the update_nonAPI_txt branch May 9, 2024 17:32
@yutannihilation
Copy link
Contributor

We've lost the majority of the AltRep API.

Just curious, which API do you call "the AltRep API"?

@CGMossa
Copy link
Member

CGMossa commented May 10, 2024

We've lost the majority of the AltRep API.

Just curious, which API do you call "the AltRep API"?

Isn't this

pub fn STDVEC_DATAPTR(x: SEXP) -> *mut ::std::os::raw::c_void;

Entirely necessary for altrep

@yutannihilation
Copy link
Contributor

No. I don't use the API at all. DATAPTR() should work. If your claim is about the unnecessary ALTREP check, I get your point. But, this is not the end of the world.

@CGMossa CGMossa mentioned this pull request May 11, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants