-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove clang-sys
dependency
#238
Conversation
I didn't know the new syntax. Is it your intention to drop
https://doc.rust-lang.org/cargo/reference/build-scripts.html |
syntax! we don't need it
Wow! Thanks! I did not know about syntax change in cargo 1.77. Yesterday, while I was trying to make this strategy work, I tried everything, and then I thought we had used the wrong syntax. I've reverted this. @Ilia-Kosenkov You asked about the |
So one explanation to the extra new items that somewhat looks like: enum {SORTED_DECR_NA_1ST = -2,
SORTED_DECR = -1,
UNKNOWN_SORTEDNESS = INT_MIN, /*INT_MIN is NA_INTEGER! */
SORTED_INCR = 1,
SORTED_INCR_NA_1ST = 2,
KNOWN_UNSORTED = 0}; these are items that stem from an anonymous C- |
This PR accomplishes three very distinct things:
Adds a missing:
infront ofcargo::
everywhere.Addsmetadata
, which have been missing frombuild.rs
foreverUpdate: the above items are unnecessary. rust 1.77 have a new syntax for
build.rs
. I didn'tcatch that initially. This has now been reverted, and MSRV for this PR is the same.
clang
/clang-sys
, by instead of the elaborate processing, we instead, ignore all items coming from headers that aren't the R-headers.