Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nonAPI.txt #248

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Update nonAPI.txt #248

merged 3 commits into from
Jun 25, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Please review the diff and run /bindings command manually.

@CGMossa
Copy link
Member

CGMossa commented Jun 17, 2024

This is particularly annoying.

@CGMossa
Copy link
Member

CGMossa commented Jun 17, 2024

I think we use REAL0 and COMPLEX0, but I think they can be exchanged for DATAPTR.

@yutannihilation
Copy link
Contributor

Just in case you missed this email.

DATAPTR is not in the API and can't be at least in this form
https://stat.ethz.ch/pipermail/r-devel/2024-June/083459.html

@CGMossa
Copy link
Member

CGMossa commented Jun 24, 2024

I'm deeply afraid of this change.
But I do get their concern somewhat.
I have a PR where I'm experimenting with a potential Elt trait to resolve these issues.

But this will prohibit us from creating slices. That's really awful. What can we do? Can we negotiate about this?

@yutannihilation
Copy link
Contributor

For REAL0 and COMPLEX0, you can simply use REAL and COMPLEX, no? At least _RO version should be available.

@CGMossa
Copy link
Member

CGMossa commented Jun 25, 2024

/bindings

Copy link
Member

@CGMossa CGMossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, due to the latest conversion about these things, I'll merge this, and see if extendr can live with these changes.

@CGMossa CGMossa merged commit 975af4e into master Jun 25, 2024
@CGMossa CGMossa deleted the update_nonAPI_txt branch June 25, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants