Detach bindgen for next release
#250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable only testing.
|
Thank you! I think we need move the deleted build contents into |
I would vote for keeping this PR clean. It removes code, and we publish it, without any clutter. Then after that, we'll make a release, and then we can bring those bits back in. |
|
I get that. Okie. Let's merge this so we can unblock CRAN fixes. |
JosiahParry
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For various reasons, we have to make a new release of
libR-sys.This PR removes all uses of
bindgen, and removes all features associated with generating bindings.The currently available bindings in
/bindingsare those that we will have until #189 is addressed.After this PR, the MSRV for
libR-sysis at: 1.58.1.