New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for empty string in use_crate() #388

Open

kbvernon wants to merge 1 commit into extendr:main from kbvernon:fix-use-crate

Contributor

kbvernon commented Sep 18, 2024

To address #387, this PR adds a check for empty strings when running purrr::discard() on the cargo_add_opts list.


          check for empty string

aeba4b7

Member

CGMossa commented Sep 18, 2024

How do we know that this works? Is it possible to add a test? Otherwise I'd just merge.

Contributor Author

kbvernon commented Sep 18, 2024

yes, this function needs a test. i'll look into adding one tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet