Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

feat: allow setting type in external secret to support other than Opaque secrets #130

Merged
merged 3 commits into from
Jul 29, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions examples/dockerconfig-example.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
apiVersion: kubernetes-client.io/v1
kind: ExternalSecret
metadata:
name: dockerhub-secret
secretDescriptor:
backendType: secretsManager
type: kubernetes.io/dockerconfigjson
data:
- key: /development/dockerhub
name: .dockerconfigjson
14 changes: 14 additions & 0 deletions examples/tls-example.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
apiVersion: kubernetes-client.io/v1
kind: ExternalSecret
metadata:
name: dockerhub-secret
secretDescriptor:
backendType: secretsManager
type: kubernetes.io/tls
data:
- key: /development/certifcate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda a nit, but

Suggested change
- key: /development/certifcate
- key: /development/certificate

property: crt
name: tls.crt
- key: /development/certifcate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- key: /development/certifcate
- key: /development/certificate

property: key
name: tls.key
2 changes: 1 addition & 1 deletion lib/poller.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class Poller {
this._ownerReference
]
},
type: 'Opaque',
type: secretDescriptor.type || 'Opaque',
data
}
}
Expand Down